[Rpm-ecosystem] Special meaning of "+" (?) separator

Igor Gnatenko ignatenko at redhat.com
Wed Sep 14 12:27:14 UTC 2016


On Wed, Sep 14, 2016 at 1:03 PM, Florian Weimer <fweimer at redhat.com> wrote:
> On 09/14/2016 10:35 AM, Igor Gnatenko wrote:
>>
>> On Wed, Sep 14, 2016 at 10:28 AM, Florian Weimer <fweimer at redhat.com>
>> wrote:
>>>
>>> On 09/09/2016 10:24 PM, Igor Gnatenko wrote:
>>>>
>>>>
>>>> during process of getting tilde approved in Fedora Packaging
>>>> Guidelines we realized that we need some special handling for
>>>> separator (most probably) "+".
>>>>
>>>> Some examples (left is what expected, right is what current situation):
>>>> 1.0+ > 1.0              | 1.0+ == 1.0
>>>> 1.0+20160101git < 1.0.1 | 1.0+20160101git > 1.0.1
>>>
>>>
>>>
>>> I thought the approach was use any encoded that would result in the
>>> desired
>>> ordering?
>>>
>>> Why not stick the "git" in the front?
>>
>> 1.0+git20160101 < 1.0.rc1
>
>
> Why is this a problem?  For RCs you need to use ~ anyway, because otherwise
> 1.0.rc1 > 1.0:
RCs was just example (probably bad example). if we use `git` before
date we just lucky that letters are sorted before numbers:
1.0.git20160101 < 1.0.1

But idea was to have something which will be higher than "base"
version, but less than anything else.
>
>>>> sorted(['1.0', '1.0.1', '1.1', '1.0+git20160101', '1.0.rc1', '1.0~rc1'],
>>>> cmp=lambda a, b: rpm.labelCompare((a, '',''), (b, '', '')))
> ['1.0~rc1', '1.0', '1.0+git20160101', '1.0.rc1', '1.0.1', '1.1']
>
>
> Florian
> _______________________________________________
> Rpm-ecosystem mailing list
> Rpm-ecosystem at lists.rpm.org
> http://lists.rpm.org/mailman/listinfo/rpm-ecosystem



-- 
-Igor Gnatenko


More information about the Rpm-ecosystem mailing list