<div dir="ltr"><div class="gmail_default" style="font-family:'times new roman',serif;font-size:large"><span style="font-family:arial,sans-serif;font-size:small">On Mon, Jun 29, 2015 at 11:30 AM, Richard Hughes </span><span dir="ltr" style="font-family:arial,sans-serif;font-size:small"><<a href="mailto:hughsient@gmail.com" target="_blank">hughsient@gmail.com</a>></span><span style="font-family:arial,sans-serif;font-size:small"> wrote:</span><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi all,<br>
<br>
I've moved the libhif repo from my personal github space to<br>
rpm-software-management. What I'm going to propose I do then is:<br>
<br>
* Merge the hawkey subtree[1] to ./hawkey<br>
* Merge the librepo subtree to ./librepo<br>
* Add the extra Makefile.am for the librepo and hawkey projects<br>
* Install the old non-introspection files as before<br>
* Stop installing the librepo and hawkey .h files unless<br>
--enable-deprecated is used<br>
* Stop installing the librepo and hawkey shared libraries unless<br>
--enable-deprecated is used<br>
* Build libhawkey and librepo into libhif.so<br>
* Kill the configure checks for librepo and hawkey in <a href="http://configure.ac" rel="noreferrer" target="_blank">configure.ac</a><br>
* Obsolete and provide the old librepo and hawkey packages in the libhif.spec<br>
<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:'times new roman',serif;font-size:large">Why in the world are you merging hawkey and librepo into libhif? We use them separately and others will want to use them separately. The fact you have configure checks for them further indicates that it makes little sense to obsolete the separate existence of these libraries. </div></div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Some comments:<br>
* I don't want to maintain everything! I think it's right the<br>
respective maintainers have control over the two different<br>
directories.<br>
* We can keep the cmake stuff that make sense in the two other<br>
projects if you're more comfortable using those; libhif is really just<br>
linking together some objects and building a tarball.<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:'times new roman',serif;font-size:large">Why not use CMake on libhif instead of making the other two use autotools? Honestly, I find using autotools to be very annoying, and CMake is generally easier for integrating into other projects, in my view</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
* We can nuke --enable-deprecated when we are sure atomic/service side<br>
depsolving has enough API in libhif.h to make it work.<br>
* when we nuke the compat switch, we can start changing API in librepo<br>
and hawkey, for instance using GList throughout and making the shared<br>
constants have the same #define name.<br>
* I don't think the code style being 100% the same is a huge problem,<br>
and changing it kills git blame.<br>
<br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:'times new roman',serif;font-size:large">I'm not sure what to say on this, as I haven't really examined the code of the libraries yet. But I'm uncomfortable with the idea of treating these libraries as a singular unit, especially since they weren't designed that way to begin with.</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
So comments welcome. If I don't hear anything by the end of the week<br>
I'll assume everything is fine and start merging trees! Feel free to<br>
nak with comments if you think I'm treading on toes.<br>
<br>
Richard<br>
<br><br></blockquote><div><br></div><div><div class="gmail_default" style="font-family:'times new roman',serif;font-size:large;display:inline">Comments given. ;)</div> </div></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">真実はいつも一つ！/ Always, there's only one truth!<br></div></div>
</div><font face="yw-402608bc37fe50adb11a5899295781aeb83d248d-5c75581256895094a6b2439973591a61--o" style></font></div>