ODP: fts.c has no business to #define reserved identifiers

[Krzysztof Żelechowski]

# defining __open is illegal in a generic environment, i.e. exactly where you try to # define it.  It should be # defined and used as FTS_open instead.

IMHO,
Chris.


Wysłane z telefonu Samsung


-------- Oryginalna wiadomość --------
Od: Florian Festi
Data:12.08.2014 10:34 (GMT+01:00)
Do: rpm-list at lists.rpm.org
Temat: Re: fts.c has no business to #define reserved identifiers

On 08/10/2014 10:25 PM, Krzysztof Żelechowski wrote:
> Is:
>
> #   define __set_errno(val) (*__errno_location ()) = (val)
>
> #   define __open           open
>
> #   define __close           close
>
> #   define __fchdir          fchdir
>
>
>
> Why do you do that?  It is illegal.

Please don't tell the Police. We all have families.
If you look a bit closer you might realize that this passage is
surrounded by the #else block of a #if defined(_LIBC) directive. So this
is only done on systems that do not come with a libc. I really have no
clue why we are supporting them but someone thought this would be
important back in 2002.

Florian
_______________________________________________
Rpm-list mailing list
Rpm-list at lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-list
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-list/attachments/20140812/92f88bbd/attachment.html>