[PATCH] Detect arm armv6hl, armv7hl and armv7hnl machines
pmatilai at laiskiainen.org
Wed Jun 25 11:35:03 UTC 2014
On 06/23/2014 07:01 PM, Lubomir Rintel wrote:
> Read presence of relevant extensions from hwcap. Loosely based on what's
> currently in use for Fedora (armv7hl) and Pidora (armv6hl).
Most of this looks fine to me...
> sys/auxv.h inclusion is made unconditional -- HAVE_GETAUXVAL signals
> presence of getauxval() call, not the header and AT_* macros defined from it
> are already used unconditionally anyways.
...but sys/auxv.h inclusion cannot be unconditional, it breaks
compilation on older glibc versions and non-Linux systems. The AT_*
macros are only used on Linux, and come from elf.h which is explicitly
included, and rpm parses /proc/auxv if glibc doesn't support getauxval()
so thats not required either.
All that rationale behind current situation doesn't obviously help
getting the required HWCAP_* macros for arm and anything else that might
need them though. Guess we could separately check for sys/auxv.h
presence and always include if there, and/or just include definitions of
the HWCAP* bits we need. Or better ideas welcome...
Thanks for working on this, its about time we get the arm bits merged
upstream. BTW rpm-maint list would be the better place for discussing
patches, rpm-list is more usage-oriented.
- Panu -
More information about the Rpm-list