[Rpm-maint] [Patch 4/19] Fix off by one in rpmal

Paul Nasrat pnasrat at redhat.com
Fri Feb 9 11:28:13 UTC 2007


This patch fixes an off-by-one error in rpmalAllFileSatisfiesDepend()
which could lead to a segfault.

Index: rpm/lib/rpmal.c
===================================================================
--- rpm.orig/lib/rpmal.c	2007-01-04 11:07:14.000000000 +0000
+++ rpm/lib/rpmal.c	2007-02-08 10:29:19.000000000 +0000
@@ -744,7 +744,7 @@
 
     /*@-branchstate@*/ /* FIX: ret is a problem */
     for (found = 0, ret = NULL;
-	 die <= al->dirs + al->numDirs && dieCompare(die, dieNeedle) == 0;
+	 die < al->dirs + al->numDirs && dieCompare(die, dieNeedle) == 0;
 	 die++)
     {
 





More information about the Rpm-maint mailing list