[Rpm-maint] [Suse-patch] Revert provides as obsoletes behavior

[Florian La Roche]

On Tue, May 22, 2007 at 12:06:45PM +0300, Panu Matilainen wrote:
> 
> Personally I never ever liked the obsoletes on provides behavior, but this 
> has been in rpm since 2001 according to hg changelogs... I don't think 
> such a dramatic behavior change is acceptable for a dot-dot-dot-dot 
> maintenance release.
> 
> I would like this changed in future major version though, as the current 
> behavior makes life miserable in some packaging scenarios.


Hello Panu,

this has now been deployed for a really long time, so I don't think we
should revert this again. While I see many packages where the obsoletes
lines match too many other packages, I am not sure if you have an
example where this is makes "life real miserable". ??

IMNSHO we should rather keep checking repo dependencies before new
packages are pushed out than changing the obsoletes behaviour to the
old minimal behaviour.

regards,

Florian La Roche





> 
> 	- Panu -
> 
> ---
> 
> Revert upstream change that uses package provides when searching
> for obsoleted packages. It's just too dangerous.
> 
> --- ./lib/depends.c.orig	2005-12-14 19:51:34.000000000 +0000
> +++ ./lib/depends.c	2006-01-27 21:05:13.000000000 +0000
> @@ -294,7 +313,7 @@ addheader:
> 
>      /* On upgrade, erase older packages of same color (if any). */
> 
> -    mi = rpmtsInitIterator(ts, RPMTAG_PROVIDENAME, rpmteN(p), 0);
> +    mi = rpmtsInitIterator(ts, RPMTAG_NAME, rpmteN(p), 0);
>      while((oh = rpmdbNextIterator(mi)) != NULL) {
> 
>  	/* Ignore colored packages not in our rainbow. */
> @@ -336,7 +355,7 @@ addheader:
>  	if (Name[0] == '/')
>  	    mi = rpmtsInitIterator(ts, RPMTAG_BASENAMES, Name, 0);
>  	else
> -	    mi = rpmtsInitIterator(ts, RPMTAG_PROVIDENAME, Name, 0);
> +	    mi = rpmtsInitIterator(ts, RPMTAG_NAME, Name, 0);
> 
>  	xx = rpmdbPruneIterator(mi,
>  	    ts->removedPackages, ts->numRemovedPackages, 1);
> _______________________________________________
> Rpm-maint mailing list
> Rpm-maint at lists.rpm.org
> https://lists.rpm.org/mailman/listinfo/rpm-maint