[Rpm-maint] [Suse patch] Disk space problem reporting

Panu Matilainen pmatilai at redhat.com
Fri May 25 07:56:52 UTC 2007


The patch commentary already says "probably a bad idea", so maybe not at 
this point... After 4.4.2.1 the plan is to go through all of rpm's error 
messages and see what can be sanitized, we should revisit this then I 
think.

 	- Panu -

---

Make the numbers reported for diskspace problems more user
friendly. Probably a bad idea, as it changes the semantics. Instead,
the messages should be changed.

--- ./lib/rpmts.c.orig	2005-02-13 03:12:03.000000000 +0000
+++ ./lib/rpmts.c	2005-12-15 15:12:10.000000000 +0000
@@ -1358,14 +1363,14 @@ void rpmtsCheckDSIProblems(const rpmts t
  	    rpmpsAppend(ps, RPMPROB_DISKSPACE,
  			rpmteNEVR(te), rpmteKey(te),
  			ts->filesystems[i], NULL, NULL,
- 	   (adj_fs_blocks(dsi->bneeded) - dsi->bavail) * dsi->bsize);
+ 	   (adj_fs_blocks(dsi->bneeded)) * dsi->bsize);
  	}

  	if (dsi->iavail > 0 && adj_fs_blocks(dsi->ineeded) > dsi->iavail) {
  	    rpmpsAppend(ps, RPMPROB_DISKNODES,
  			rpmteNEVR(te), rpmteKey(te),
  			ts->filesystems[i], NULL, NULL,
- 	    (adj_fs_blocks(dsi->ineeded) - dsi->iavail));
+ 	    (adj_fs_blocks(dsi->ineeded)));
  	}
      }
      ps = rpmpsFree(ps);



More information about the Rpm-maint mailing list