[Rpm-maint] Migration from Beecrypt to NSS

[Tomas Mraz]

On Thu, 2007-11-01 at 14:18 +0100, Tomas Mraz wrote:
> On Thu, 2007-11-01 at 15:08 +0200, Panu Matilainen wrote:
> > On Thu, 1 Nov 2007, Ralf Corsepius wrote:
> > 
> > > On Thu, 2007-11-01 at 12:10 +0100, Tomas Mraz wrote:
> > >> The patch https://bugzilla.redhat.com/attachment.cgi?id=245451
> > >> which I have attached to
> > >> https://bugzilla.redhat.com/show_bug.cgi?id=348131
> > >> provides migration of RPM from using Beecrypt to NSS.
> > >>
> > >> The patch should apply to the current 4.2.2 branch.
> > >>
> > >> As NSS base64 encoding support is not as flexible as we need I have
> > >> imported and modified base64 encoding source from public domain base64
> > >> encoder project http://libb64.sourceforge.net/.
> > >>
> > >> The patch shouldn't break any public API/ABI.
> > >>
> > >> Comments? Reviews?
> > 
> > Looks sane to me, ignoring the fact that I'm blissfully ignorant of inner 
> > crypto :) Cursory testing shows it appears to work too, and even slightly 
> > faster (a few percents on my laptop) than with beecrypt.
> > 
> > > IMO, this step is a great idea, however at least I would prefer to let
> > > major changes (such as this) to go into the trunk, first.
> > 
> > Sure. We actually agreed with Tomas he'd do the initial development against 
> > 4.4.x to have a stable base to work on as HEAD's been in quite a bit of 
> > flux and then forward port it.
> > 
> > > Would it be possible to provide a patch against the trunk?
> > 
> > I already started looking at it, although Tomas or someone else beats me 
> > to it I wont mind ;)
> I'm already porting it and I'm almost finished as there were no
> substantial changes in the code touched by the patch. I'll attach the
> trunk patch to the bug report.

I've attached the trunk patch to the bug report here:
https://bugzilla.redhat.com/attachment.cgi?id=245941

The trunk patch compiles fine but I didn't test if it is working. I did
that only with the 4.2.2 branch patch.

-- 
Tomas Mraz
No matter how far down the wrong road you've gone, turn back.
                                              Turkish proverb