[Rpm-maint] various bug fixes (patches)

Michael Schroeder mls at suse.de
Tue Nov 13 11:29:21 UTC 2007


On Tue, Nov 13, 2007 at 11:50:03AM +0100, Pixel wrote:
> Hi, Mandriva is currently using rpm 4.4.8. We are investigating the
> cost to switch to 4.4.2.2
> 
> Since August 2007, Mandriva uses "Suggests", which is implemented in
> rpm 4.4.3 (?). In rpm 4.4.2.x, there is already partial support for it
> since RPMSENSE_MISSINGOK flag is already there.
> 
> I've crafted a patch. It should be /mostly/ clean.
> 
> - it modifies unsatisfiedDepend() to take RPMSENSE_MISSINGOK into account
> - it adds "--suggests" and "--enhances" to rpmquery
>   (the biggest part of the patch: lib/formats.c, rpmpopt.in
> - it supports Suggests and Enhances in .spec
> - it adds Requires(hint) in .spec 
>   (as done in rpm >= 4.4.3, Mandriva doesn't use it though)
> 
> Could this be merged in?


Hmm, IIRC rpm-4.4.8 puts suggests/enhances into the normal rpm
requires, which is incompatible with rpm versions that don't
understand the RPMSENSE_MISSINGOK flag.
I'd prefer the way we (SUSE) do it by putting the suggests/enhances
in the already existing tags and leaving the requires alone. Or
is that also the way Mandriva does it?

Cheers,
  Michael.

-- 
Michael Schroeder                                   mls at suse.de
SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg
main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);}



More information about the Rpm-maint mailing list