[Rpm-maint] [PATCH] forbid #%define

Manfred Hollstein mh at novell.com
Fri Jun 6 13:16:17 UTC 2008


On Fri, 06 Jun 2008, 13:41:41 +0200, Per Øyvind Karlsen wrote:
> [...]
> My argument is that %macros isn't shell scripts, even if they're mixed, '#'
> isn't even always the equivalent of a comment either in all cases, all
> depending on context.

If you look at the original post from Pixel with a patch included, the
request was about addressing some "magic" going on behind the scenes
wrt/ evaluating %define's when someone might believe they're not, and
just generating an appropriate diagnostics instead. The whole issue wasn't
directly linked with a particular location in .spec files (at least not
to me), but reminded me, that I have been hit by exactly this several
times in the past. I know, that one shouldn't use '#' as a general-purpose
comment character, but thought, that from a general point of view (clear
syntax etc.), it wouldn't be too bad to provide a fix in the right
direction (which Panu's fix did IMHO)...

Last message from me in this regard.

Cheers.

l8er
manfred



More information about the Rpm-maint mailing list