[Rpm-maint] [PATCH] Move header reading part from rpminstall to tryReadHeader function.

[Panu Matilainen]

On Fri, 24 Apr 2009, Rakesh Pandit wrote:

> 2009/4/23 Panu Matilainen wrote:
>> On Sat, 14 Mar 2009, Rakesh Pandit wrote:
> [..]
>> - A further cleanup suggestion: with this patch it becomes very obvious that
>> eiu->fd is only used locally in the tryReadFoo() functions and can (and
>> should) be eliminated from struct rpmEIU.
>>
>
> This one:
>
> http://rakesh.fedorapeople.org/rpm/0001-Removed-rpmEIU-struct-member-fd-and-its-usage-in-t.patch
>
> I have kept fd name -- it seemed apt to me.

Obviously :) Just one thing: there's little point in setting fd = NULL on 
exit paths now that it's just a local variable.

 	- Panu -