[Rpm-maint] [PATCH] Moving notify flag setting to a common place.
pmatilai at redhat.com
Tue Feb 10 08:56:51 UTC 2009
On Mon, 19 Jan 2009, Rakesh Pandit wrote:
> Move notify flag settings from rpmInstall and rpmErase to rpmSetNotifyFlag.
> As you can see
> -rpmVSFlags rpmSetVSFlags(struct rpmInstallArguments_s * ia)
> +static rpmVSFlags rpmSetVSFlags(struct rpmInstallArguments_s * ia)
> +static void rpmSetNotifyFlag(struct rpmInstallArguments_s * ia,
> + rpmts ts)
> I have kept both previous patch common function and this one static.
> Upto this patch rpmErase has become clean and very simple to
> understand. rpmInstall is still a big dragon. :(
Heh, dragon indeed...
> Comments and suggestions ? Suggestions on Naming of functions are also
> welcome ?
Seems ok to me. I guess I should start dusting off my erasure
progress patches, or at least try to locate them first :)
As for naming, most of static, internal helper functions in rpm are
without the rpm-prefix (so these'd be setvsFlags() and setNotifyFlags() or
so) , but it's not consistent as some things have moved from being
exported to static and vice versa. For static functions, doesn't matter
- Panu -
More information about the Rpm-maint