[Rpm-maint] [PATCH] re-factoring rpmInstall & rpmErase - merging common code & removing redundancy

[Rakesh Pandit]

Hello list,

Well holidays made me lazy and some other stuff kept me busy and could
not update my earlier mails.

Attached are updated coherent patches(updated all earlier mailed
patches). I have fixed earlier patches to make them pass test suite
and few cosmetic changes. My aim was refactoring of rpmInstall &
rpmErase and removing any symmetric algorithm code between them. The
basic aim being to implement last in ideas page[1] i.e "conflicting
updates".

I have kept them as small as possible, though first two may look long
but that is just because of merging and corresponding renaming of
structure members.

First patch[1]:

 - Merge rpmInstallInterfaceFlags_e and rpmEraseInterfaceFlags_e to
rpmCliInterfaceFlags_e.
 - Renamed (UN)?INSTALL_* to RPMCLI_* and all corresponding changes in
different interface related files.

Second patch[2]:

 - Merged installInterfaceFlags and eraseInterfaceFlags into cliInterfaceFlags.
 - Moved transaction part from rpmInstall and rpmErase to rpmCliTransaction.

Third patch [3]:

 -Remove stopinstall variable and moved rpmcliPackagesTotal to correct place.
 -Changes in rpmInstallSource for getting reused in install mode and removed

[1] http://rpm.org/wiki/Problems/Upgrade
[2] http://rakesh.fedorapeople.org/misc/0001--Merge-rpmInstallInterfaceFlags_e-and-rpmEraseInter.patch
[3] http://rakesh.fedorapeople.org/misc/0002--Merged-installInterfaceFlags-and-eraseInterfaceFlag.patch
[4] http://rakesh.fedorapeople.org/misc/0003--Remove-stopinstall-variable-and-moved-rpmcliPackage.patch

Attached are files.

-- 
rakesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: first.patch
Type: text/x-patch
Size: 13657 bytes
Desc: not available
Url : http://lists.rpm.org/pipermail/rpm-maint/attachments/20090115/5aaadd82/attachment-0003.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: second.patch
Type: text/x-patch
Size: 14286 bytes
Desc: not available
Url : http://lists.rpm.org/pipermail/rpm-maint/attachments/20090115/5aaadd82/attachment-0004.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: third.patch
Type: text/x-patch
Size: 3182 bytes
Desc: not available
Url : http://lists.rpm.org/pipermail/rpm-maint/attachments/20090115/5aaadd82/attachment-0005.bin