[Rpm-maint] [PATCH] Move header reading part from rpminstall to tryReadHeader function.

Rakesh Pandit rakesh.pandit at gmail.com
Sat Mar 14 11:14:58 UTC 2009


2009/3/13 Panu Matilainen wrote:
> On Wed, 11 Mar 2009, Rakesh Pandit wrote:
[..]
> Seems sane to me, just a minor nit:
> [pmatilai at localhost rpm]$ make -j4 > /dev/null
> rpminstall.c: In function ‘tryReadHeader’:
> rpminstall.c:328: warning: unused variable ‘rc’
>
> Somewhat related thing (not introduced by this): while cleaning things up
> and moving things about, might as well get rid of those silly unused "xx"
> variables. Either the return code should be checked for and acted upon, or
> in cases like this where you just dont care if Fclose() succeeds or not,
> just ignore it.
>
>        - Panu -

Thanks.

Updated: http://rakesh.fedorapeople.org/rpm/0001--Move-header-reading-part-from-rpminstall-to-tryRea.patch

-- 
Regards,
Rakesh Pandit


More information about the Rpm-maint mailing list