[Rpm-maint] [PATCH 14/19] Detect possible policy module conflicts

James Antill james at fedoraproject.org
Fri Feb 5 17:54:58 UTC 2010

On Tue, 2010-02-02 at 15:25 -0500, Steve Lawrence wrote:
> +       if (rstreq(headerGetString(h, RPMTAG_NAME), RPMPOL_PKG_NAME))
> {
> +               pol->source = headerGetAsString(h, RPMTAG_SOURCERPM);
> +       } else {
> +               pol->source = headerGetAsString(h, RPMTAG_NAME);
> +       }

 While this is much better than "(none)", I'm not sure why you are
treating different packages from within the same specfile
differently ... and also SOURCERPM contains NVR, not just name.

 And again, you now have your own "obsoletes, requires and conflicts"
processing. And frankly the missing provides are probably a bug (having
packages which don't provide at least their name will be "interesting").
Just make real packages.

More information about the Rpm-maint mailing list