[Rpm-maint] [PATCH 4/6] Create a new publicly accessible function, rpmteHeaderOpen

Panu Matilainen pmatilai at laiskiainen.org
Mon Jul 26 11:48:55 UTC 2010

On Wed, 14 Jul 2010, Steve Lawrence wrote:

> When the SELinux policy collection plugin is executed, the transaction
> element has already been closed, and the header cannot be accessed.
> However, access to the header is needed to extract policy data. The new
> rpmteHeaderOpen function allows accessing the header of a closed
> transaction element by opening it if necessary.

Is there a chance that this gets called on packages which are not yet 
installed? If so, I suspect it'll confuse the heck out of yum's (and 
probably others) transaction callback/progress handling. Also there's no 
guarantee the package file exists after its installed (eg depsolvers might 
delete packages after installing to save diskspace).

rpmteHeader() is already a somewhat strange interface, adding another 
similar doesn't make it any better... but I don't have any concrete ideas 
off-hand how to make it all saner. One possibility might be having another 
opetional collection hook which gets executed while the element header is 
open to permit whatever data the plugins might need to be collected from 
the headers.

 	- Panu -

More information about the Rpm-maint mailing list