[Rpm-maint] [PATCH 2/5] Determine when to perform Collection actions

Panu Matilainen pmatilai at laiskiainen.org
Mon Jun 21 08:24:46 UTC 2010

On Mon, 21 Jun 2010, Panu Matilainen wrote:
> ...but then you need to be careful not t use rpmtdFreeData() or argvFree() on 
> the returned piece, but instead just free() it as headerGet() returns it all 
> in a single allocation block. Also you can't modify p->collections afterwards 
> if done that way which limits other possibilities so its probably best left 
> as is.

Doh, hasty send-finger-syndrome strikes. To clarify the "modify 
afterwards" part: AFAICS the current implementation doesn't need to modify 
the collections in any way, but allowing it to be modified permits some 
interesting possibilities like additional run-time detected collections 
based on path patterns. Which brings us to "file triggers" using the same 
mechanism. But that's beyond the scope of this patch-set, just thought to 
mention it.

One more "please fix" stylistical nit on the patches: please fix the patch 
set to use rpm indentation style. Block indents are four characters wide, 
done with a combination of hard tabs of the default 8 chars + soft tabs of 
4 spaces. Rpm's codebase is by no means strict K&R but 'indent -kr' gives 
close enough results for the indentation. With that + the bits from other 
comments done, I think we can just apply the patches and work from there. 
There's no immediate release pending so there's time to ponder and fiddle 
with the implementation details.

 	- Panu -

More information about the Rpm-maint mailing list