[Rpm-maint] [PATCH] Add __version__ and __version_info__ to python module

Panu Matilainen pmatilai at laiskiainen.org
Mon May 3 12:10:32 UTC 2010


On Fri, 30 Apr 2010, james at fedoraproject.org wrote:

> From: James Antill <james at and.org>
>
> ---
> python/Makefile.am        |    6 +++
> python/rpm/__init__.py    |   75 -------------------------------------------
> python/rpm/__init__.py.in |   78 +++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 84 insertions(+), 75 deletions(-)
> delete mode 100644 python/rpm/__init__.py
> create mode 100644 python/rpm/__init__.py.in
>
> diff --git a/python/Makefile.am b/python/Makefile.am
> index f50c103..1a96642 100644
> --- a/python/Makefile.am
> +++ b/python/Makefile.am
> @@ -11,6 +11,12 @@ AM_CPPFLAGS += -I at WITH_PYTHON_INCLUDE@
> pkgpyexec_LTLIBRARIES = _rpmmodule.la _rpmbmodule.la
> pkgpyexec_DATA = rpm/__init__.py rpm/transaction.py
>
> +rpm/__init__.py: rpm/__init__.py.in
> +	@$(SED) \
> +	  -e "s,[@]VERSION[@],$(VERSION),g" \
> +	  < $(top_srcdir)/$(subdir)/rpm/__init__.py.in > rpm/__init__.py
> +CLEANFILES = rpm/__init__.py

Um, what's wrong with just using rpm.version symbol which is already 
exported to python in HEAD? 
http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=21962ab6142cd1e54f1087a545244de506d9abf1

 	- Panu -


More information about the Rpm-maint mailing list