[Rpm-maint] [PATCH] Performance improvement of rpmfcSaveArgs

Giulio Eulisse Giulio.Eulisse at cern.ch
Wed Jan 26 15:01:17 UTC 2011

> The rpmfc structures probably want a rewrite at this point really, but I think I'll add your argvSortedInsert() as a static function within rpmfc.c until then. That way we dont end up with an unused function in the public API once the problematic ARGV usage is fixed in rpmfc - there are other places with similar add+sort loops where it might be useful, but really anything requiring performance tweaks to ARGV is better off using a better data structure for the purpose.

That would be perfect for now, thanks. Do you think you'll be able to include the fix in 4.9.0?

> Thanks for looking into this and the patch!

Thank you for following this up.


More information about the Rpm-maint mailing list