[Rpm-maint] [PATCH 2/2] Recognize "<epoch>:" as a part of a label (ticket #117)
pmatilai at laiskiainen.org
Tue Nov 15 10:16:14 UTC 2011
On 11/15/2011 11:37 AM, Panu Matilainen wrote:
> Why the malloc? AFAICS you could just have "int epoch = 0" in
> dbiFindByLabel() and pass the pointer to that to splitEpoch(), only
> changing the value if one was actually found, equaling the "no epoch
> equals zero epoch" behavior and avoiding couple seemingly unnecessary
> malloc/free on what's a fairly busy path.
Erm, correction: busy path this is not by any strectch of imagination.
The malloc/frees just seem like a wholly unnecessary complication, thats
- Panu -
More information about the Rpm-maint