[Rpm-maint] [PATCH 3/3] rpmio: Indent code (minor)

Panu Matilainen pmatilai at laiskiainen.org
Tue Oct 11 10:26:49 UTC 2011


On 09/29/2011 10:09 AM, Mukund Sivaraman wrote:
> ---
>   rpmio/rpmio.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/rpmio/rpmio.c b/rpmio/rpmio.c
> index 2434687..b0aa5a0 100644
> --- a/rpmio/rpmio.c
> +++ b/rpmio/rpmio.c
> @@ -1169,7 +1169,8 @@ static int lzdClose(FD_t fd)
>
>       lzfile = lzdFileno(fd);
>
> -    if (lzfile == NULL) return -2;
> +    if (lzfile == NULL)
> +	return -2;
>       rc = lzclose(lzfile);
>
>       /* XXX TODO: preserve fd if errors */

NAK. Rpm codebase is full of these constructs, and while the style might 
not be exactly encouraged, I don't consider it "illegal" either. 
Changing just one of them just for the heck of it isn't going to make 
life any better, and I certainly don't want to see hundreds of such 
patches :)

	- Panu -


More information about the Rpm-maint mailing list