[Rpm-maint] [PATCH] - Added support for ppc64p7 arch (Power7 and higher optimized)

Panu Matilainen pmatilai at laiskiainen.org
Thu Apr 12 09:48:09 UTC 2012

On 04/11/2012 12:58 PM, Phil Knirsch wrote:
> Attached is the updated version of the ppc64p7 support patch. I've got
> rid of the AUXV env reading and doing it properly now via reading and
> parsing /proc/self/auxv. Additionally the patch now checks if the
> AT_PLATFORM is power7 or higher via a sscanf(), allowing future power
> architectures to benefit from it as well.

The patch leaks file descriptors, the fd it opens is never closed.
In the cosmetics department you might want to split the long if with 
sscanf() into two separate if's (or otherwise reformat) to avoid the 
large line-wrap which is easily avoidable.

Other than that, looks okay to me.

	- Panu -

More information about the Rpm-maint mailing list