[Rpm-maint] Obsoletes handling in depends.c:rpmdbProvides()
pmatilai at laiskiainen.org
Fri Apr 20 06:08:34 UTC 2012
On 04/18/2012 06:10 PM, Michael Schroeder wrote:
> Hi Panu et al,
> I'm a bit confused about commit 9fb81eac. If dep is an
> "Obsoletes" dependency, it uses RPMDBI_NAME instead of
> RPMDBI_PROVIDENAME. It then still calls rpmdsMatchesDep().
> Is that really correct? It seems to me that rpmdsMatchesDep()
> always expects the "ix" argument to be an index into the
> provides error, how can that work with a different db index?
> Also, shouldn't it call rpmdsNVRMatchesDep() in the
> obsoletes case instead of rpmdsMatchesDep() to be more
> consistent with addObsoleteErasures()?
It does look fishy alright, thanks for pointing that out. Note the
commit message: I did have a feeling there might be something more to it
so it doesn't say its "correct" but "(more) correct" :)
- Panu -
More information about the Rpm-maint