[Rpm-maint] [PATCH] Don't lose errno from rpmPackageFilesInstall

Panu Matilainen pmatilai at laiskiainen.org
Thu Aug 15 04:50:35 UTC 2013


On 06/27/2013 08:39 PM, Andreas Schwab wrote:
> There are a lot of ways to lose the value of errno after a failed
> rpmPackageFilesInstall.  Typically, stdio will call isatty which then
> overwrites errno with ENOTTY.  Save and restore errno between the return
> from rpmPackageFilesInstall and the logging of the error.  There may be
> more opportunities inside rpmPackageFilesInstall to clobber the real
> errno which I haven't investigated yet.

Apologies for very late reply, first this stuck on moderation queue an 
then I was away on vacation and ... stuff.

There are indeed likely to be many more places where errno gets lost, 
but this looks okay to me. Applied, thanks for the patch!

	- Panu -

More information about the Rpm-maint mailing list