[Rpm-maint] PATCH 1/2013 Take rid of redefinitions of __BEGIN_DECLS and __END_DECLS

Kamil Rytarowski n54 at gmx.com
Thu Aug 15 18:00:04 UTC 2013


----- Original Message -----
From: Panu Matilainen
Sent: 08/15/13 06:51 AM
To: n54 at gmx.com
Subject: Re: [Rpm-maint] PATCH 1/2013 Take rid of redefinitions of __BEGIN_DECLS and __END_DECLS

On 07/25/2013 06:38 PM, n54 at gmx.com wrote: > Hello, Hi, > I'm attaching a patch with the following change-log: > > 1. Stop defining __BEGIN_DECLS and __END_DECLS in fts.h > 2. Replace occurences of __BEGIN_DECLS with: > extern "C" { > 3. Replace occurences of __BEGIN_DECLS with: > } > > Comment > ======= > __BEGIN_DECLS and __END_DECLS are already defined in the NetBSD's standard C > library as an internal definition and redefinition of it causes errors. > > The possible solutions are to rename the definitions or take rid of them. > > Actually __BEGIN_DECLS and __END_DECLS are used only once and encapsulate > 'extern "C" {' and '}', so they aren't really helping more then obfuscating > the code. Cleanups always welcome. Applied, thanks for the patch! - Panu -
Hello,
Thank you!
There is another declaration doing the same (but this time not clashing with libc internals) in rpmio/rpmutil.h: RPM_BEGIN_DECLS, RPM_END_DECLS.
Can we nuke it too?
Regards,
Kamil Rytarowski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20130815/1b08997d/attachment.html>


More information about the Rpm-maint mailing list