[Rpm-maint] PATCH 1/2013 Take rid of redefinitions of __BEGIN_DECLS and __END_DECLS

Kamil Rytarowski n54 at gmx.com
Fri Aug 16 12:26:43 UTC 2013


Yes, this looks better to introduce, into the RPM code. But as it's already defined by C libraries, I would use another names, like RPM_BEGIN_DECLS and RPM_FUN_PROTOTYPE.

What do you think?
----- Original Message -----
From: devzero2000
Sent: 08/15/13 10:56 PM
To: n54 at gmx.com
Subject: Re: [Rpm-maint] PATCH 1/2013 Take rid of redefinitions of __BEGIN_DECLS and __END_DECLS

Hmm, libtool propose another, perhaps better, solution


But ymmv

On Thu, Jul 25, 2013 at 5:38 PM, < n54 at gmx.com > wrote:Hello,

I'm attaching a patch with the following change-log:

1. Stop defining __BEGIN_DECLS and __END_DECLS in fts.h
2. Replace occurences of __BEGIN_DECLS with:
extern "C" {
3. Replace occurences of __BEGIN_DECLS with:

__BEGIN_DECLS and __END_DECLS are already defined in the NetBSD's standard C
library as an internal definition and redefinition of it causes errors.

The possible solutions are to rename the definitions or take rid of them.

Actually __BEGIN_DECLS and __END_DECLS are used only once and encapsulate
'extern "C" {' and '}', so they aren't really helping more then obfuscating
the code.

Kamil Rytarowski

Rpm-maint mailing list
 Rpm-maint at lists.rpm.org 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20130816/fdd823bc/attachment.html>

More information about the Rpm-maint mailing list