[Rpm-maint] digest_beecrypt cleanup
pmatilai at laiskiainen.org
Wed Aug 28 17:50:23 UTC 2013
On 08/28/2013 08:11 PM, Michael Schroeder wrote:
> On Wed, Aug 28, 2013 at 06:54:24PM +0200, Michael Schroeder wrote:
>> On Wed, Aug 28, 2013 at 06:52:48PM +0200, Michael Schroeder wrote:
>>> On Wed, Aug 28, 2013 at 02:39:35PM +0300, Panu Matilainen wrote:
>>>> No objections to the changes as such, but please split the patch up a bit:
>>>> at the very least separate the interface change from the beecrypt-cleanups,
>>>> but I wouldn't mind the beecrypt cleanups further split up either. That bit
>>>> of extra work pays itself back every time when the inevitable git-bisect
>>>> time cometh...
>>> git-bisect? You don't trust my code? Ts...
Oh, I dont trust anybody's code, my own very much included...
I've just seen too many trivial/seemingly obvious patches to rpm cause
bizarre, often seemingly unrelated issues much later on, and small
commits simply makes life oh so much easier at that point.
>>> Anyway, appended as 4 patches in git format-patch form.
>> Stupid mailer missed two of them. Sigh. Now all four patches.
> Seems like I forgot to split off the padding change, here's a changed
> part 4 and a new part5.
Nice. All applied, and thanks for the patches and bothering to split the
- Panu -
More information about the Rpm-maint