[Rpm-maint] FSM hooks for rpm plugin

Panu Matilainen pmatilai at laiskiainen.org
Mon Feb 18 14:29:38 UTC 2013

On 02/05/2013 12:59 PM, Reshetova, Elena wrote:
> Hi,

Hi, sorry about the delay... the recent patch-flood on rpm-maint caught 
me by surprise :)

> Here is the new version attached. The reason I didn't attach it in the last
> email was because I couldn't rearrange the " this particular jungle " in any
> reasonable way and was still wondering what to do with it :)
> But I will wait for you now to brush it first!
> I am leaving this peace untouched from previous version, but other places are
> adjusted as discussed.

Yup, the jungle and the beasts within need to be tamed first :)

I've cleaned it up somewhat now, for example the early return was just 
plain wrong as it would've leaked resources all over the place. But then 
it also was a case that could never be reached at all...

The code still looks suspicious in many places and wants further 
inspection and sanitizing but achieving symmetrical behavior for the 
hooks might actually be possible now. At least its *closer* to that 
target if not there yet :)

	- Panu -

More information about the Rpm-maint mailing list