[Rpm-maint] FSM hooks for rpm plugin

Reshetova, Elena elena.reshetova at intel.com
Wed Feb 20 09:01:00 UTC 2013


>Hi, sorry about the delay... the recent patch-flood on rpm-maint caught me by 
>surprise :)
Patch flood is always good, total silence is much worse :)

>I've cleaned it up somewhat now, for example the early return was just plain 
>wrong as it would've leaked resources all over the place. But then it also 
>was a case that could never be reached at all...
>The code still looks suspicious in many places and wants further inspection 
>and sanitizing but achieving symmetrical behavior for the hooks might 
>actually be possible now. At least its *closer* to that target if not there 
>yet :)

I think it looks much better now and integrating hooks to it is a pleasure. I 
am attaching the new version. Hope I didn't miss any strange case, but it 
looked very easy now after your change!

Best Regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Adding-FSM-file-hooks.patch
Type: application/octet-stream
Size: 10345 bytes
Desc: not available
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20130220/593503fa/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 7220 bytes
Desc: not available
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20130220/593503fa/attachment-0001.p7s>

More information about the Rpm-maint mailing list