[Rpm-maint] [PATCH] export rpmdsCompareEVR()
pmatilai at laiskiainen.org
Tue Jan 8 13:04:48 UTC 2013
On 12/24/2012 04:38 PM, Thierry Vignaud wrote:
> The following patch exports rpmdsCompareEVR().
> It enables to simplify perl-URPM by not having to create temporary rpmds objects
> in order to check for dependency overlap (when all it needs is name,
> evr and flags.).
> Please commit into master and 4.11.x.
I think I said in our earlier (private) discussions that while I can see
exporting something like it, I dont want to export rpmdsCompareEVR() as
it is. IIRC the main issues are:
1) Parts of the flags semantics are still handled in
rpmdsCompareIndex(), so you might get different results from "raw"
rpmdsCompareEVR() vs creating the rpmds objects and calling
rpmdsCompare() on them.
2) Such a function should also accept the dependency names too, probably
handling NULL names as a legal "assume same" value.
3) Calling the function rpmdsSomething isn't right as it doesn't
actually deal with rpmds objects.
Also I'm loathe to add any further exposure to the "nopromote" crapola
of the past. The legacy behavior needs to be preserved somehow but it'd
preferrably be buried six feet under in the internals for new interfaces.
- Panu -
More information about the Rpm-maint