[Rpm-maint] [PATCH] plugins/systemd_inhibit.c: Define DBUS_TYPE_UNIX_FD if undefined.
pmatilai at laiskiainen.org
Tue Mar 5 20:05:17 UTC 2013
On 03/05/2013 09:38 PM, Mark Wielaard wrote:
> On Tue, Mar 05, 2013 at 07:15:30PM +0200, Panu Matilainen wrote:
>> Hum... dbus 1.2.24 would be RHEL-6'ish, right? In which case the
>> whole plugin makes no sense at all because it actually needs to have
>> a fairly recent systemd running on the system to do anything at all.
>> Dunno, I can certainly apply that but then again it might make more
>> sense to not even try compiling it with dbus that old, as anything
>> with that old dbus version is highly unlikely to be running systemd
>> in the first place (which however is something that cannot be tested
>> for during build)
> Yes, RHEL 6.4 to be precise. An alternative would be checking for
> dbus 1.3+ which has DBUS_TYPE_UNIX_FD. See attached.
Right. Given the target of that plugin requiring dbus >= 1.3 seems fair
(the 1.0 version requirement was really just drawn out of a hat)
Applied, thanks for the patch!
- Panu -
More information about the Rpm-maint