[Rpm-maint] FSM hooks for rpm plugin

Reshetova, Elena elena.reshetova at intel.com
Wed Mar 6 15:02:52 UTC 2013

>Another issue I just realized is that with this patch, the metadata hook call 
>is not under the setmeta condition so it will get called always, ie in cases 
>like hardlinks when it specifically should *not* be called :)

>I think the fsm-part should be something like this instead:

@@ -1569,6 +1569,11 @@ static int fsmCommit(FSM_t fsm, int ix, int setmeta)

      if (setmeta) {
+       /* Run fsm metadata hook for all plugins */
+       if (!rc) {
+           rc = rpmpluginsCallFsmFileMetadata(fsm->plugins,
+                                               fsm->path, st, fsm->action);
+       }
          /* Set file security context (if enabled) */
          if (!rc && !getuid()) {
              rc = fsmSetSELabel(fsm->sehandle, fsm->path, fsm->sb.st_mode);

Ups, indeed, will fix!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 7220 bytes
Desc: not available
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20130306/9b3e56e1/attachment.p7s>

More information about the Rpm-maint mailing list