[Rpm-maint] Add appdata() and application() auto-provides

Michael Schroeder mls at suse.de
Fri Oct 4 12:01:26 UTC 2013

On Wed, Oct 02, 2013 at 07:32:26PM -0400, Colin Walters wrote:
> +               echo "application()"
> +               echo "application(${instfile##*/applications/})"
>                 if ! grep -q '^Type=Application$' "$instfile"; then continue; fi
>                 if ! grep -q '^Exec=' "$instfile"; then continue; fi
> Shouldn't these pairs of lines be swapped, so that we don't
> emit provides for things that aren't actually Type=Application for
> example?

I also saw that "if" statement, but decided to put the echo statements
before it. My reasoning is that the application() marker is for
.desktop files in the "/usr/share/applications" directory, independent
of the type. (I must admit that I have no clue about what other types
are allowed in those desktop files.)


Michael Schroeder                                   mls at suse.de
SUSE LINUX Products GmbH,  GF Jeff Hawn, HRB 16746 AG Nuernberg

More information about the Rpm-maint mailing list