[Rpm-maint] [rpm-software-management/rpm] Build fixes related to <bfd.h> (#108)

Mark Wielaard mjw at redhat.com
Thu Dec 8 23:44:09 UTC 2016

Hi rpm-maint,

On Thu, 2016-12-08 at 15:08 -0800, Thomas Petazzoni wrote:
> You can view, comment on, or merge this pull request online at:
>   https://github.com/rpm-software-management/rpm/pull/108

I am not sure what to make of this mail message, or how to properly
reply. It is somewhat inconvenient to not have the patch to review in
the message or attached but having to click-through and download it
separately. Assuming these emails are generated automatically could they
be changed to just include the patch.

>   * Detect bfd.h to enable/disable sepdebugcrcfix building
>   * tools/sepdebugcrcfix.c: fix build with recent binutils

I think the reliance on bfd.h was a mistake. The code was lifted from
bfd, but should be totally independent (it just calculates a CRC). The
attached fixes the type to be a normal size_t and include sys/stat.h
(which was included through bfd.h) to get the definitions of stat and



-------------- next part --------------
A non-text attachment was scrubbed...
Name: sepdebugcrcfix-no-bfd.patch
Type: text/x-patch
Size: 739 bytes
Desc: not available
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20161209/377901ee/attachment.bin>

More information about the Rpm-maint mailing list