[Rpm-maint] Unable to build after Stop messing with CFLAGS from configure patch

Panu Matilainen pmatilai at laiskiainen.org
Fri Dec 9 09:41:00 UTC 2016

On 12/09/2016 10:41 AM, Mark Wielaard wrote:
> Hi,
> commit bd3eb213 "Stop messing with CFLAGS from configure" renamed
> rpm.am to rpm.am.in. rpm.am is included am into all Makefile.am files.
> But rpm.am is now generated by configure. Which means it is generated
> in the builddir so the includes should reference top_builddir instead of
> top_srcdir now. But when running automake (or autoreconf) configure
> doesn't even exist yet, so there is no rpm.am file yet and automake
> will fail to generate proper Makefile.in files.
> Could we instead do it like the attached by just defining the
> AM_CFLAGS substitution inside the Makefile.am files themselves?
> Thanks,

I thought I tested the "bootstrap" case but guess not :-/ I was really 
hoping to have a single place for setting that stuff in the makefiles 
but oh well...

Applied, thanks for the patch and sorry 'bout the breakage.

	- Panu -

More information about the Rpm-maint mailing list