[Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .<num>~ suffix by def… (#109)

soig notifications at github.com
Fri Dec 9 14:40:42 UTC 2016


On 9 December 2016 at 04:03, proyvind <notifications at github.com> wrote:

> …ault
>
> The legacy mandriva %apply_patches macro by default generated backup
> files with unique suffixes by default, the suffix for patch0 being
> .0001~ etc.
>
> As for those of us still using gendiff, this is still convenient, while
> for those using a scm, the '~' at end of suffix will anyways be
> automatically ignored, so enabling it by default won't interfer.
>
> A -B argument passed to the %autopatch will disable this.
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
>   https://github.com/rpm-software-management/rpm/pull/109
> Commit Summary
>
>    - When using %autopatch, create backup files with .<num>~ suffix by
>    default
>
> File Changes
>
>    - *M* macros.in
>    <https://github.com/rpm-software-management/rpm/pull/109/files#diff-0>
>    (10)
>
> Patch Links:
>
>    - https://github.com/rpm-software-management/rpm/pull/109.patch
>    - https://github.com/rpm-software-management/rpm/pull/109.diff
>
>> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/rpm-software-management/rpm/pull/109>, or mute the
> thread
> <https://github.com/notifications/unsubscribe-auth/AC5qkY0vJh2feiza-uspthP4-fOgHz6Fks5rGMUHgaJpZM4LIiHk>
> .
>

​
Actually, in Mageia where we used extensively %apply_patches as the
mandriva legacy, we found out taht the backup behaviour not pleasant as
this makes several packages to silently package backup files
If one really wants backups, (s)he just has to use "%autosetup -S git" and
the like

​See eg: https://bugs.mageia.org/show_bug.cgi?id=15579

I remember having seen other strange and rare build issues due to backup
files, so please no, we don't want backup by default and since we've great
support for SCMs, there's no point in having such an option.
My 2 cents


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/109#issuecomment-266028997
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20161209/e7247df7/attachment.html>


More information about the Rpm-maint mailing list