[Rpm-maint] [PATCH 0/3] find-debuginfo.sh speedup

Michal Marek mmarek at suse.com
Sat Jul 2 19:11:18 UTC 2016


Dne 2.7.2016 v 16:28 Mark Wielaard napsal(a):
> Hi,
> 
> On Fri, 2016-07-01 at 22:43 +0200, Michal Marek wrote:
>> this series allows find-debuginfo.sh to run in parallel. It also makes the
>> duplicate build-id links predictable.
> 
> The build-id link code was completely rewritten in one of the patches I
> wrote some weeks ago:
> http://lists.rpm.org/pipermail/rpm-maint/2016-June/004365.html
> 
> Could you look at how your changes interact with that? I think your "3/3
> find-debuginfo.sh: Process files in parallel" patch should work as is
> with that cleanup.

OK, I will have a look.


> And do you have any testcases for this or could you check with the
> testcases in the above patch set to see if it has the right behavior?
> It adds a rpmbuildid.at that explicitly checks generating build-id
> symlinks for binaries that are hard linked and/or have duplicate
> build-ids.

I do not have any systematic testcases, but in my random testing I found
a race in patch 3/3: Using a named pipe was not a good idea, because a
job might open it too late and hang forever. So I will be posting a v2 soon.

Michal


More information about the Rpm-maint mailing list