[Rpm-maint] [PATCH] RFC: Add build-id links to rpm for all ELF.
mjw at redhat.com
Thu Jun 2 14:35:55 UTC 2016
On Thu, 2016-06-02 at 08:36 -0400, Lubos Kardos wrote:
> I skimmed through your patches and they seem ok to me from a coding style point
> of view. I would suggest just cosmetic changes like replacing asprintf() with
> rasprintf() and on some places 8 spaces are used instead of tab
> for indentation.
I hadn't noticed rasprintf. Is that just asprintf using xmalloc?
I'll fix the code to use that and double check whitespace changes.
> The problem with patches is that they move some logic from the debugedit
> tool to rpm which is something I and Florian don't like.
Yeah, I had to move the symlinking code from find-debuginfo.sh (which
uses debugedit to get the build-ids) to the main rpm code since there is
no way for find-debuginfo.sh to add anything to an existing package file
list. And the whole goal of the patch is to not have all the build-id
symlinks in the same place in the debuginfo package since they will go
stale there when the main subpackage and the debuginfo package don't
match up (which we do want to allow so you can create parallel
installable debuginfo packages).
Let me know how you like me to improve the code/logic.
I just posted a new version of the patch which still needs some extra
tests and handle duplicate build-ids like the find-debuginfo.sh script
More information about the Rpm-maint