[Rpm-maint] [PATCH v9 09/13] Add file signature support to package signing

[Thierry Vignaud]

On 11 May 2016 at 22:35, Thierry Vignaud <thierry.vignaud at gmail.com> wrote:
>> This patch modifies rpmSign to include file signatures in the header.
>> Since the header is altered, the package digest and package+archive
>> digest need to be recalculated and updated in the signature header.
>> Defer resigning the header digests to replaceSignature().
>>
>> Changelog:
>> - remAdd file signature support to package signing
>
> The following change makes perl-RPM4's testsuite to fail due to segfault:
> (see attached gdb trace)
>
>> @@ -720,5 +878,5 @@ int rpmPkgSign(const char *path, const struct rpmSignArgs * args)
>>
>>  int rpmPkgDelSign(const char *path)
>>  {
>> -    return rpmSign(path, 1);
>> +    return rpmSign(path, 1, 0);
>>  }
>
> The attached patch fixes that.
> It's against the 4.13.x branch but should apply on master too.
>
> Please apply
> Thanks

Ping?
the doc explicitely describe "args" as "signing parameters (or NULL for
defaults)"

This no more true since commit 6e9eab345a18d01f0c2c35fa8bb842744093364c
As such, with rpm-4.13, some callers will segfault (eg: perl-RPM4's
testsuite)