[Rpm-maint] [rpm-software-management/rpm] Fix off-by-one error (#68)

Stefan Berger notifications at github.com
Wed May 25 18:39:37 UTC 2016


> @@ -104,7 +104,7 @@ static int base64_decode_value(unsigned char value_in)
>  {
>  	static const int decoding[] = {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51};
>  	value_in -= 43;
> -	if (value_in > sizeof(decoding)/sizeof(int))
> +	if (value_in >= sizeof(decoding)/sizeof(int))

my 2 cents: also change to sizeof(decoding)/sizeof(decoding[0])

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/68/files/0964912b94f9f48a0a812fbfbb2f996dbd93eff0#r64628600
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20160525/19f4798b/attachment.html>


More information about the Rpm-maint mailing list