[Rpm-maint] [PATCH] Extend %changelog to support full timestamps

Pavlina Varekova varekpaf at seznam.cz
Mon Oct 10 07:36:54 UTC 2016


Od: Panu Matilainen <pmatilai at laiskiainen.org>
"On 10/07/2016 01:33 PM, Pavlina Varekova wrote:

> I fixed the "CEST 2016 in author field" bug in [1], thanks for spotting
> it. I will add this to the pull request once I incorporate the strptime
> function (it's usage has one side-effect: it is locale sensitive but I
> assume changelog timestamp must be always in "C" locale not in e.g.
> fr_FR - it would be quite complex to assume any locale in input).

Correct, %changelog always needs to be in "C" locale.

- Panu -"



I try a lot to simplify the parsing by using strptime() function, but it has
problems with timezone:
- only %z store timezone is implemented to read time zone into  tm_gmtoff 
item, but
- tm_gmtoff item isn't sometimes implemented/present in tm struct
- sometimes even macro HAVE_TM_GMTOFF to test the presence isn't implemented

So at the end, I would have to parse and deal with the timezone manually.

Therefore I suggest a patch without using strptime() function that accepts 
textual (CEST) format of timezone. The patch fixes the bug Panu found and 
incorporates feedback from Panu and Florian W.

Do you agree with this patch?




Pavlina

""
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20161010/572b07d8/attachment.html>


More information about the Rpm-maint mailing list