[Rpm-maint] [PATCH] Fix misleading-indentation in rpmplugins.c

Neal Gompa ngompa13 at gmail.com
Tue Sep 20 00:26:18 UTC 2016

On Thu, Sep 15, 2016 at 8:53 AM, Mark Wielaard <mjw at redhat.com> wrote:
> GCC6 will warn about:
> lib/rpmplugins.c: In function ‘rpmpluginsCallInit’:
> lib/rpmplugins.c:217:5: warning: this ‘if’ clause does not guard...
>      if (hookFunc)
>      ^~
> lib/rpmplugins.c:219:9: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
>          if (rc != RPMRC_OK && rc != RPMRC_NOTFOUND)
>          ^~
> GCC is right, this is misleading and causes the if statement to be executed
> even when it isn't necessary. It doesn't actually cause wrong results
> because rc is initialized to RPMRC_OK earlier and can only change when
> hookFunc != NULL.

Looks good to me, and should be okay to apply!

真実はいつも一つ!/ Always, there's only one truth!

More information about the Rpm-maint mailing list