[Rpm-maint] [rpm-software-management/rpm] Add macro to force fsync() on close() (#187)

Jeff Johnson notifications at github.com
Thu Apr 6 07:27:05 UTC 2017


@jayzmh - add a static variable to expand the macro as a "one shot" ... there are many places in rpm that do that, hurts little (until rpm can capture global configuration object).

Meanwhile I recommend the *_DONTNEED mmap implementation instead of fsync. RPM used that for years, and *_DONTNEED was originally suggested by Ben LaHaise (a linux kernel developer) as the right implementation (particularly for what you want): let the kernel manage its resources, don't try to devise some configurable opt-in policy permitting an application using fsync to second guess (or permit sysadmins the pretense of second guessing) kernel resource management algorithms.

Meanwhile: do you have measurements that you can report?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/187#issuecomment-292091677
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170406/e63ab35e/attachment.html>


More information about the Rpm-maint mailing list