[Rpm-maint] [rpm-software-management/rpm] Add macro to force fsync() on close() (#187)

Jeff Johnson notifications at github.com
Thu Apr 6 21:25:54 UTC 2017


@jayzmh: major invasive change to ... RPM? or something else?

I'll happily write the code for rpm.org RPM if you wish. I fail to see how reverting to what RPM used to do (i.e. use mmap with MADV_DONTNEED and most importantly for you using msync(MS_ASYNC) which schedules flush to disk like fsync freeing resources but returns immediately permitting RPM to continue its software updating.

There's another approach using O_SYNC/O_DSYNC which I've not looked at because (correctly) added to POSIX and linux in 2008, which is long after I looked/measured the original mmap implementation. But lets not go to O_SYNC/O_DSYNC until MADV_DONTNEED is measured please.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/187#issuecomment-292327785
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170406/df992dfe/attachment.html>


More information about the Rpm-maint mailing list