[Rpm-maint] [PATCH] debugedit: Only output comp_dir under build dir (once).

Panu Matilainen pmatilai at redhat.com
Mon Apr 24 11:02:06 UTC 2017


On 04/21/2017 06:33 PM, Mark Wielaard wrote:
> The fix for rhbz#444310 (commit c1a5eb - Include empty CU current dirs)
> was a little greedy. It would also include comp_dirs outside the build
> root. Those are unnecessary and we don't have a good way to store them.
> Such dirs (e.g. /tmp) would then show up at the root of /usr/src/debug.
> 
> Fix this by including only comp_dirs under base_dir. Also only output
> all dirs once (during phase zero) and don't output empty dirs (which
> was harmless but would produce a warning from cpio).
> 
> This still includes all empty dirs from the original rhbz#444310
> nodir testcase and it is an alternative fix for rhbz#641022
> (commit c707ab).
> 
> Both fixes are necessary in case of an unexpected mode for a directory
> actually in the build root that we want to include in the source list.
> 
> Signed-off-by: Mark Wielaard <mark at klomp.org>
> ---

And applied, thanks for the patch.

	- Panu -


More information about the Rpm-maint mailing list