[Rpm-maint] [rpm-software-management/rpm] Add OpenSSL crypto backend (#129)

Panu Matilainen notifications at github.com
Tue Feb 7 10:53:49 UTC 2017


pmatilai commented on this pull request.



> +    switch (num) {
+    case 0:
+        if (!bn) {
+            bn = sig->bn = BN_new();
+        }
+        if (!bn) return 1;
+
+        /* Create a BIGNUM from the signature pointer.
+           Note: this assumes big-endian data as required
+           by the PGP multiprecision integer format
+           (RFC4880, Section 3.2)
+           This will be useful later, as we can
+           retrieve this value with appropriate
+           padding. */
+        bn = BN_bin2bn(p+2, mlen, bn);
+        if (!bn) return 1;

Oh, my recollection of beecrypt requiring padding is from some ancient comment by somebody, somewhere, so either I'm misremembering, things have changed since then or the commenter was wrong. Or any combination of the three. Sorry, didn't intend to spread misinformation.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/129
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170207/383385c5/attachment.html>


More information about the Rpm-maint mailing list