[Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

[Neal Gompa (ニール・ゴンパ)]

Conan-Kudo requested changes on this pull request.

I'd prefer that the new extra scripts be disabled by default for now, rather than enabled by default.

In addition, instead of using `dont_`, I'd suggest using `enable_` or `disable_` and wording it appropriately. That's consistent with other feature flag macros in RPM.

The desktop files one should be changed to `fix_desktop_files` rather than `fix_xdg`, because the former is more descriptive of what it is actually fixing.

I do not believe the rpath or pkgconfig ones should exist at all, as I think there are too many ways that could break things unintentionally.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-20776925
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170208/6383a594/attachment.html>