[Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
Neal Gompa (ニール・ゴンパ)
notifications at github.com
Wed Feb 8 14:55:48 UTC 2017
Conan-Kudo requested changes on this pull request.
I'd prefer that the new extra scripts be disabled by default for now, rather than enabled by default.
In addition, instead of using `dont_`, I'd suggest using `enable_` or `disable_` and wording it appropriately. That's consistent with other feature flag macros in RPM.
The desktop files one should be changed to `fix_desktop_files` rather than `fix_xdg`, because the former is more descriptive of what it is actually fixing.
I do not believe the rpath or pkgconfig ones should exist at all, as I think there are too many ways that could break things unintentionally.
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Rpm-maint