[Rpm-maint] [rpm-software-management/rpm] Fix pythondistdeps.py --provides for Python wheels (#154)

Florian Festi notifications at github.com
Wed Feb 15 12:07:46 UTC 2017

ffesti requested changes on this pull request.

Other than the bit sloppy RE this looks good.

>          if not dist.py_version:
-            warn("Version for {!r} has not been found".format(dist), RuntimeWarning)
-            continue
+            # Try to parse the Python version from the path the metadata
+            # resides at (e.g. /usr/lib/pythonX.Y/site-packages/...)
+            import re
+            res = re.search("/python(?P<pyver>[0-9.]{3})/", path_item)

Can you please use a more precise RE pattern . E.g.
\\d\\.\\d or [0-9]\\.[0-9] instead of 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170215/a92e2583/attachment.html>

More information about the Rpm-maint mailing list