[Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)

proyvind notifications at github.com
Thu Jan 12 05:46:25 UTC 2017

proyvind commented on this pull request.

> @@ -0,0 +1,14 @@
+# If using normal root, avoid changing anything.
+if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then
+	exit 0
+find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la  -print0 |
+xargs  --no-run-if-empty -0 file -N -L |
+grep "libtool library file" |
+sed -e 's#: libtool library file.*##g' |

For the brp-check-elf-files script, it's hard to contest that more work has been put into yours than pixel (I'm guessing) put into writing the original perl script, which I've simply rewritten in bash.

Yet for the brp- scripts, I'm a firm believer in KISS, where I really think the brp* scripts should be self-contained and for single purpose only with as little complexity as possible.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170111/a530e546/attachment.html>

More information about the Rpm-maint mailing list