[Rpm-maint] [rpm-software-management/rpm] Do not expand macro in a comment. (#123)

MyungJoo Ham notifications at github.com
Thu Jan 12 09:58:28 UTC 2017


Although %% can disable macro expansion, requiring to add another %
to % in a commented-out lines is not intuitive to most developers and
we are observing many mistakes in spec files.

With multi-line macros, expanding macros in a comment is disasterous
and is hard to find the errors for developers who do not know that
using % in # may be disasterous, which is very not common for other
scripting languages.

Because expanding a single-line macro in a comment has no effect on
the behaviors of rpm-build and expanding multi-line macro in a comment
has no value as a scripting syntax, I'd like to suggest that we do not
expand macros in a comment.

Related issue: #121 

Signed-off-by: MyungJoo Ham <myungjoo.ham at samsung.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/123

-- Commit Summary --

  * Do not expand macro in a comment.

-- File Changes --

    M build/parseSpec.c (10)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/123.patch
https://github.com/rpm-software-management/rpm/pull/123.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/123
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rpm.org/pipermail/rpm-maint/attachments/20170112/1262d3c5/attachment.html>


More information about the Rpm-maint mailing list